Skip to content

Fix reinstall test failing on MacOS due to rsync change#6954

Merged
hjoliver merged 2 commits intocylc:8.5.xfrom
MetRonnie:macos-rsync
Sep 3, 2025
Merged

Fix reinstall test failing on MacOS due to rsync change#6954
hjoliver merged 2 commits intocylc:8.5.xfrom
MetRonnie:macos-rsync

Conversation

@MetRonnie
Copy link
Copy Markdown
Member

@MetRonnie MetRonnie commented Sep 1, 2025

For some reason on GH Actions MacOS we have started seeing "recv" instead of "send" in rsync here:

REINSTALL cit-20250901T091622Z/test_reinstall/test_permissions_change/52f05762 from /private/var/folders/x7/ch5v91h56_zbvbd1y2f600dm0000gn/T/pytest-of-runner/pytest-1/popen-gw4/test_permissions_change0/src
.f...p... recv myscript

\x1b[38;5;248mTIP: You can "exclude" files/dirs to prevent Cylc from installing or overwriting
     them by adding them to the .cylcignore file. See cylc reinstall --help.\x1b[0m

\x1b[1mReinstall would make the above changes.\x1b[0m
\x1b[35mNo changes made: reinstall cancelled.\x1b[0m

Possibly macos-latest has changed to 15

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No dependency changes or tests or changelog or docs needed
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@MetRonnie MetRonnie added this to the 8.5.2 milestone Sep 1, 2025
@MetRonnie MetRonnie self-assigned this Sep 1, 2025
@MetRonnie MetRonnie added the small label Sep 1, 2025
@MetRonnie MetRonnie marked this pull request as draft September 1, 2025 11:13
@MetRonnie MetRonnie marked this pull request as ready for review September 1, 2025 11:45
@MetRonnie MetRonnie changed the title Fix test failing on MacOS Fix reinstall test failing on MacOS due to rsync change Sep 1, 2025
@oliver-sanders
Copy link
Copy Markdown
Member

oliver-sanders commented Sep 1, 2025

The change is a tad concerning.

The change from send => recv suggests a change of perspective from server => client which is rather odd.

I don't think we do any remote stuff on the Mac OS tests, so I guess the server and client are the same host. Maybe that's it?

@MetRonnie
Copy link
Copy Markdown
Member Author

MetRonnie commented Sep 1, 2025

My guess is macos-latest has changed to 15 this week and on the new runner rsync is behaving in "pull" mode even though it is still local: https://github.com/cylc/cylc-flow/actions/runs/17375118712/job/49319610412#step:8:1178

rsync -a --checksum --out-format=%o %n%L --no-t --delete --exclude=/_cylc-install --exclude=/rose-suite.conf /private/var/folders/x7/ch5v91h56_zbvbd1y2f600dm0000gn/T/pytest-of-runner/pytest-1/popen-gw1/test_permissions_change0/src/ /Users/runner/cylc-run/cit-20250901T103938Z/test_reinstall/test_permissions_change/a4afc7cb/ --out-format=%i %o %n%L

The tests still pass as the files are being copied correctly

Edit: tested

$ rsync -an --out-format='%i %o %n%L' localhost:/path/to/file /path/to/elsewhere

and get the same recv output instead of send if you remove localhost:

Apparently sometimes local transfers can happen in "pull" mode instead of "push" mode
Copy link
Copy Markdown
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The explanation seems vaguely plausible.

Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
@hjoliver hjoliver merged commit da0705b into cylc:8.5.x Sep 3, 2025
38 of 39 checks passed
@MetRonnie MetRonnie deleted the macos-rsync branch September 3, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants