Skip to content

config: load Jupyter application-specific config files#784

Open
oliver-sanders wants to merge 1 commit intocylc:masterfrom
oliver-sanders:jupyter-application-specific-config-files
Open

config: load Jupyter application-specific config files#784
oliver-sanders wants to merge 1 commit intocylc:masterfrom
oliver-sanders:jupyter-application-specific-config-files

Conversation

@oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Jan 27, 2026

  • Load jupyterhub_config.py files for JupyterHub.
  • Load jupyterserver_config.py files for Jupyter Server.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders oliver-sanders added this to the 1.9.0 milestone Jan 27, 2026
@oliver-sanders oliver-sanders self-assigned this Jan 27, 2026
@oliver-sanders oliver-sanders force-pushed the jupyter-application-specific-config-files branch from b2f2f2f to 2cc2a6c Compare January 27, 2026 10:23
@oliver-sanders oliver-sanders requested a review from wxtim January 27, 2026 10:27
Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@oliver-sanders
Copy link
Member Author

I can't see evidence of jupyter_server.py files being loaded.

Sounds like grounds to reject?

@wxtim
Copy link
Member

wxtim commented Jan 29, 2026

I can't see evidence of jupyter_server.py files being loaded.

Sounds like grounds to reject?

Refresh page? I followed up explaining my daft mistake.

@oliver-sanders
Copy link
Member Author

oliver-sanders commented Feb 19, 2026

Refresh page? I followed up explaining my daft mistake.

No, I agree with your comment, that file ain't loaded!

It's looking for jupyter_cylc_config.py (because we're loading it through the extension it uses the extension name, not the jupyter application name)

* Load `jupyterhub_config.py` files for JupyterHub.
* Load `jupyter_cylc_config.py` files for Cylc UI Server.
@oliver-sanders oliver-sanders force-pushed the jupyter-application-specific-config-files branch from 2cc2a6c to b162b70 Compare February 19, 2026 16:55
@oliver-sanders oliver-sanders requested a review from wxtim February 19, 2026 16:55
@oliver-sanders
Copy link
Member Author

@wxtim, corrected the filename and added some documentation.

Please could you double check this makes sense and the filepaths are correct (print statements in the files is a reasonable acid test).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants