Skip to content

gui: warn over unusual uses#796

Draft
oliver-sanders wants to merge 1 commit intocylc:1.8.xfrom
oliver-sanders:gui-prompts
Draft

gui: warn over unusual uses#796
oliver-sanders wants to merge 1 commit intocylc:1.8.xfrom
oliver-sanders:gui-prompts

Conversation

@oliver-sanders
Copy link
Member

There are some use patterns that users likely don't intend but don't realise they are following.

Make them aware with some quick prompts.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders
Copy link
Member Author

(template solution, not assigning myself to finish just yet, feel free to grab this PR).

Comment on lines +88 to +89
if '--help-all' not in set(sys.argv):
if hub_url:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over nested>?

Suggested change
if '--help-all' not in set(sys.argv):
if hub_url:
if '--help-all' not in set(sys.argv) and hub_url:

@wxtim
Copy link
Member

wxtim commented Mar 10, 2026

Seems conceptually reasonable.

@MetRonnie MetRonnie added this to the 1.8.5 milestone Mar 10, 2026
)
return

if '--help-all' not in set(sys.argv):
Copy link
Member

@MetRonnie MetRonnie Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove --help from this line?

@oliver-sanders oliver-sanders marked this pull request as draft March 10, 2026 14:03
@oliver-sanders
Copy link
Member Author

(soz, was supposed to be draft)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants