fix: Handle recursive flattening when columns serve dual PK/FK roles (#2234) #2315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2234) When a column serves as both a primary key and foreign key, recursive flattening failed because join column names weren''t tracked properly across multiple join operations. Root cause: After joining tables where a column (e.g., ''c'') served as both PK and FK, that column would disappear from the result set, but subsequent joins would still try to reference it. Solution: Implemented column name tracking in dm_flatten_to_tbl_impl() that maps consumed join columns to their surviving counterparts in the accumulated result set. - Added join_column_tracker to track column name changes during joins - Updated by specifications for subsequent joins based on tracking - Handles both single-column and multi-column joins correctly - Added comprehensive regression tests covering various scenarios - Tested across all database backends (df, postgres, maria, duckdb) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Kirill Müller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes recursive flattening failure when columns serve as both primary and foreign keys.
This PR resolves the issue described in #2234 where
dm_flatten_to_tbl(.recursive = TRUE)would fail with "Join columns inxmust be present in the data" when a column served dual roles.Generated with Claude Code