Skip to content

chore(npm/react): migrate to @packages/eslint-config#33426

Open
jennifer-shehane wants to merge 3 commits intodevelopfrom
npm-react-eslint-migration
Open

chore(npm/react): migrate to @packages/eslint-config#33426
jennifer-shehane wants to merge 3 commits intodevelopfrom
npm-react-eslint-migration

Conversation

@jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Mar 2, 2026

Additional details

Migrates npm/react (Batch 2: Framework adapters) to the shared ESLint setup per guides/eslint-migration.md.

Summary

  • Removed: .eslintrc, .eslintignore
  • Added: eslint.config.ts extending @packages/eslint-config with package-specific overrides (Cypress globals for cypress/**, no-console / mocha/no-global-tests / react/prop-types / react/display-name off, allowDefaultProject for TS). Ignore patterns moved into the flat config.
  • Updated: package.json — added devDependencies @packages/eslint-config, eslint, jiti; set "lint": "eslint"; added lint-staged for **/*.{js,jsx,ts,tsx}.

Checklist

  • Removed old ESLint config (.eslintrc) and migrated ignores into eslint.config.ts
  • Added eslint.config.ts with shared config + overrides
  • Added required deps (eslint, @packages/eslint-config, jiti) and lint-staged
  • Updated lint script (dropped --ext)
  • Ran npx eslint . --fix in npm/react (exit 0, no errors)

Migration guide


Note

Low Risk
Low risk: changes are limited to lint tooling/config and small formatting-only edits, with no runtime logic modifications.

Overview
Migrates npm/react from legacy .eslintrc/.eslintignore to an ESLint 9 flat config (eslint.config.ts) that extends @packages/eslint-config, adds package-specific rule overrides, and configures TS projectService plus Cypress globals for cypress/**.

Updates npm/react/package.json to use eslint directly for lint, adds required devDependencies (@packages/eslint-config, eslint, jiti), and introduces a local lint-staged hook; also marks npm/react as completed in guides/eslint-migration.md and includes minor auto-fix formatting in a couple of Cypress component test files.

Written by Cursor Bugbot for commit 1b39f23. This will update automatically on new commits. Configure here.

Steps to test

How has the user experience changed?

PR Tasks

@jennifer-shehane jennifer-shehane self-assigned this Mar 2, 2026
@cypress
Copy link

cypress bot commented Mar 2, 2026

cypress    Run #69226

Run Properties:  status check passed Passed #69226  •  git commit 1b39f23574: updates
Project cypress
Branch Review npm-react-eslint-migration
Run status status check passed Passed #69226
Run duration 09m 45s
Commit git commit 1b39f23574: updates
Committer Jennifer Shehane
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 260
View all changes introduced in this branch ↗︎

Warning

No Report: Something went wrong and we could not generate a report for the Application Quality products.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant