chore(npm/react): migrate to @packages/eslint-config#33426
Open
jennifer-shehane wants to merge 3 commits intodevelopfrom
Open
chore(npm/react): migrate to @packages/eslint-config#33426jennifer-shehane wants to merge 3 commits intodevelopfrom
jennifer-shehane wants to merge 3 commits intodevelopfrom
Conversation
cypress
|
||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
npm-react-eslint-migration
|
| Run status |
|
| Run duration | 09m 45s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
2
|
|
|
0
|
|
|
260
|
| View all changes introduced in this branch ↗︎ | |
Warning
No Report: Something went wrong and we could not generate a report for the Application Quality products.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional details
Migrates npm/react (Batch 2: Framework adapters) to the shared ESLint setup per guides/eslint-migration.md.
Summary
.eslintrc,.eslintignoreeslint.config.tsextending@packages/eslint-configwith package-specific overrides (Cypress globals forcypress/**,no-console/mocha/no-global-tests/react/prop-types/react/display-nameoff,allowDefaultProjectfor TS). Ignore patterns moved into the flat config.package.json— added devDependencies@packages/eslint-config,eslint,jiti; set"lint": "eslint"; addedlint-stagedfor**/*.{js,jsx,ts,tsx}.Checklist
.eslintrc) and migrated ignores intoeslint.config.tseslint.config.tswith shared config + overrideseslint,@packages/eslint-config,jiti) andlint-staged--ext)npx eslint . --fixinnpm/react(exit 0, no errors)Migration guide
Note
Low Risk
Low risk: changes are limited to lint tooling/config and small formatting-only edits, with no runtime logic modifications.
Overview
Migrates
npm/reactfrom legacy.eslintrc/.eslintignoreto an ESLint 9 flat config (eslint.config.ts) that extends@packages/eslint-config, adds package-specific rule overrides, and configures TSprojectServiceplus Cypress globals forcypress/**.Updates
npm/react/package.jsonto useeslintdirectly forlint, adds required devDependencies (@packages/eslint-config,eslint,jiti), and introduces a locallint-stagedhook; also marksnpm/reactas completed inguides/eslint-migration.mdand includes minor auto-fix formatting in a couple of Cypress component test files.Written by Cursor Bugbot for commit 1b39f23. This will update automatically on new commits. Configure here.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?