dependency: remediate minimatch, serialize-javascript, and vite vulnerabilities#33461
Open
MuazOthman wants to merge 5 commits intodevelopfrom
Open
dependency: remediate minimatch, serialize-javascript, and vite vulnerabilities#33461MuazOthman wants to merge 5 commits intodevelopfrom
MuazOthman wants to merge 5 commits intodevelopfrom
Conversation
- Bump minimatch from 3.1.2 to 3.1.3 in data-context, driver, and network packages to address ReDoS vulnerability - Add yarn resolutions to pin minimatch across transitive dependencies (lerna, nx, editorconfig, graphql-config, mocha, serve-handler) - Add serialize-javascript 7.0.3 resolution to fix XSS vulnerability - Remove obsolete socket.io-parser resolution - Bump vite from 3.2.11 to 4.5.12 in outdated-deps test projects and update corresponding e2e test assertions - Bump Angular 21 test project dependencies from ^21.0.0 to ^21.2.0
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
- Change mocha-7.2.0/minimatch resolution from 5.1.8 to 3.1.3 since mocha 7.2.0 depends on minimatch ^3.0.4, which is incompatible with the 5.x major version. This removes the unused minimatch@5.1.8 entry from yarn.lock.
…pgrades - Add dependency update changelog entries for minimatch 3.1.3 and serialize-javascript 7.0.3 vulnerability remediations in PR #33461
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
muaz/vuln-20260310
|
| Run status |
|
| Run duration | 16m 56s |
| Commit |
|
| Committer | Muaz Othman |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
10
|
Skipped
|
0
|
Passing
|
647
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
0%
|
|
|---|---|
|
Untested elements
|
4
|
|
Tested elements
|
0
|
Accessibility
100%
|
|
|---|---|
|
Failed rules
|
0 critical
0 serious
0 moderate
0 minor
|
|
Failed elements
|
0
|
jennifer-shehane
changed the title
Member
|
@MuazOthman The Semantic Pull Request check is failing because we're in the middle of a release, so ignore that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional details
What changed
minimatchfrom 3.1.2 to 3.1.3 indata-context,driver, andnetworkpackagesminimatchacross transitive dependencies (lerna, nx, editorconfig, graphql-config, mocha, serve-handler)^3.0.4range)serialize-javascript7.0.3 resolutionsocket.io-parser4.0.5 resolution (was itself vulnerable to CVE-2023-32695)vitefrom 3.2.11 to 4.5.12 in outdated-deps test projects and update corresponding e2e test assertionsCVEs Addressed
minimatch (3.1.2 → 3.1.3, resolutions for 9.0.7)
*compiles to a separate[^/]*?regex group causing O(4^N) backtracking**(GLOBSTAR) segments causing O(C(n,k)) combinatorial backtracking inmatchOne()*()extglobs produce regexps with nested unbounded quantifiersserialize-javascript (→ 7.0.3)
RegExp.flags— incomplete fix for CVE-2020-7660 allows code injection when serialized output is evaluatedvite (3.2.11 → 4.5.12 in test projects)
server.fs.denybypass on case-insensitive file systems exposing.envand sensitive filesserver.fs.denybypass — directory glob patterns only match basename due to picomatch bugserver.fs.denybypass using?import&rawquery parameter?raw??bypassingserver.fs.denyand@fspath traversalserver.fs.denybypass via?inline&importor?raw?importserver.fs.denybypass via.svgwith.wasm?initand relative path traversalsocket.io-parser (removed 4.0.5 pin)
Steps to test
yarn install— verify it succeeds with no resolution conflictsconfig-warning.cy.tse2e tests — verify they pass with updated vite version assertionsHow has the user experience changed?
No user-facing changes. These are internal dependency upgrades to remediate known vulnerabilities, plus test fixture updates to match the new dependency versions.
PR Tasks
cypress-documentation?type definitions?Note
Medium Risk
Mostly dependency pinning, but changes to Yarn
resolutionscan have repo-wide install/build impact and may surface incompatibilities in tooling or transitive consumers.Overview
Primarily security-driven dependency remediation: bumps
minimatchto3.1.3in several packages and adds Yarnresolutionsto force safeminimatch/serialize-javascriptversions across transitive dependency trees (and drops the priorsocket.io-parserpin).Updates test fixtures and assertions to match refreshed dependency versions (e.g. Vite version shown in Launchpad dependency-warning e2e tests) and refreshes Angular system-test project dependencies; also bumps CI cache version and records the dependency updates in the CLI changelog.
Written by Cursor Bugbot for commit fd19d1d. This will update automatically on new commits. Configure here.