fix(vite-dev-server): wait for support file and retry dynamic imports to avoid CI race#33487
Draft
fix(vite-dev-server): wait for support file and retry dynamic imports to avoid CI race#33487
Conversation
cypress
|
||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
mschile/vite_failed_dynamic_import
|
| Run status |
|
| Run duration | 08m 48s |
| Commit |
|
| Committer | Matthew Schile |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
1
|
|
|
0
|
|
|
739
|
| View all changes introduced in this branch ↗︎ | |
Warning
No Report: Something went wrong and we could not generate a report for the Application Quality products.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional details
initCypressTests.jsbefore the Vite dev server has finished serving the support file or spec module, leading to "Failed to fetch dynamically imported module" and flaky failures.@cypress/vite-dev-serverstartup and the client-side dynamic imports in the test iframe (support file + spec).server.listen(), we now wait until the support file URL returns HTTP 200 (waitUntilUrlReady) so "dev server ready" is deterministic. NewwaitForSupportFile.tsbuilds the same URL path the client uses and polls until 2xx. (2) Client: Dynamic imports for the support file and spec(s) are wrapped inretryDynamicImport()(up to 4 attempts, 400ms apart) for retryable errors (e.g. "Failed to fetch", "dynamically imported module", "Importing a module script failed").Steps to test
yarn workspace @cypress/vite-dev-server test -- waitForSupportFile.spec.tsHow has the user experience changed?
PR Tasks
cypress-documentation?type definitions?