-
Notifications
You must be signed in to change notification settings - Fork 94
ci: add test project #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add test project #252
Conversation
|
jennifer-shehane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There tends to be issues sometimes hitting the https://jsonplaceholder.cypress.io URL, because of how we rate limit those requests. Not a blocker, just bringing it up if that ends up becoming a pattern to watch for.
|
Thanks for updating the "Cypress App" term!
Actually this will not be a possible pattern here because CircleCI doesn't run Cypress. It only runs ESLint against the Cypress scaffolded project code. Cypress is only used in development to scaffold the project, then it is uninstalled. In CircleCI Cypress is not installed at all. There are instructions in the README for running Cypress locally and that is the only situation where https://jsonplaceholder.cypress.io would come into play. So I think we're good. 🙂 |
This comment was marked as resolved.
This comment was marked as resolved.
|
🎉 This PR is included in version 4.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |

Situation
Currently CI tests running in the circle.yml pipeline provide the following coverage:
npm run eslintnpm testnpm run test:legacyTests showing
eslint-plugin-cypressrunning in typical end-user configurations are missing. This represents a test coverage gap.If there are any problems with the package definition and content provided by package.json or with the examples in the README document this would not be picked up by the current tests.
Change
test-projectconfigured with the default set of full scaffolded Cypress tests.Non-goal
End-user testing of legacy (deprecated non-flat) configurations.