test: convert pnpm workflow to os matrix #1226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This comment was marked as outdated.
This comment was marked as outdated.
jennifer-shehane
approved these changes
Jul 29, 2024
|
🎉 This PR is included in version 6.7.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
aayushshah15
pushed a commit
to useblacksmith/cypress-io
that referenced
this pull request
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Several jobs in the workflow .github/workflows/example-basic-pnpm.yml are repeated with the only difference being the operating system:
ubuntu-20.04ubuntu-22.04windows-latestmacos-latestThe final job
basic-pnpm-without-binary-installis proof that issue #327 from 2021 was resolved. This job is redundant, since it was copied from .github/workflows/example-basic.yml and it does not correspond to an actual full use-case, since no tests are run.The jobs use
npxwhich is not a nativepnpmcommand.Change
Convert the workflow into a GitHub Actions matrix for the following operating systems, preferring fixed versions from the available GitHub Actions runner images, equivalent to current
latesttags:ubuntu-22.04windows-2022macos-14Replace npx using pnpm exec.
Drop the job
basic-pnpm-without-binary-install.