Add provider options for DB Connection Pools #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add in provider options for DB Connection Pools The defaults maintain the current configuration, but this allows users to tune db connections for individual needs. In particular, even with the latest go libraries, we often encounter "cannot allocate memory" errors when creating yet another DB connection. We have a large number of resources across multiple DBs, so this happens frequently. For our uses, enabling connection pooling is going to save us a lot of headaches and the edge case disabling the connection pooling is guarding against unlikely to be an issue. * Use `any` and add some documentation for connection timing (cherry picked from commit c546ea4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The defaults maintain the current configuration, but this allows users to tune db connections for individual needs.
In particular, even with the latest go libraries, we often encounter "cannot allocate memory" errors when creating yet another DB connection. We have a large number of resources across multiple DBs, so this happens frequently. For our uses, enabling connection pooling is going to save us a lot of headaches, and the edge case disabling the connection pooling is guarding against unlikely to be an issue.