configure.ac: clarify --enable/--disable usage#566
Open
dilyanpalauzov wants to merge 1 commit intocyrusimap:masterfrom
Open
configure.ac: clarify --enable/--disable usage#566dilyanpalauzov wants to merge 1 commit intocyrusimap:masterfrom
dilyanpalauzov wants to merge 1 commit intocyrusimap:masterfrom
Conversation
If a feature is enabled by default `./configure --help` should print '--disable-feature' and the called concludes from this output that the feature is enabled by default, even if the text after '--disable-feature' doesn't state this explicitly. Likewise, if a feature is disabled by default `./configure --help` should print '--enable-feature' without stating, that the default is no. -- switch all calls of AC_ARG_ENABLE to use AC_HELP_STRING -- siwth DIGEST from AC_ARG_ENABLE to AC_ARG_WITH, because it accepts a parameter, which is unusual for AC_ARG_WITH -- exploit the fact that AC_ARG_ENABLE(x, text,,) sets $enable_x, when --enable-x is called, so don't set the variable explicitly -- reduce the calls of AC_ARG_RESULT -- make ./configure --disable-macos-framework do the right thing -- Remove unnecessary quoting, like "yes" → yes.
Contributor
|
Please update your commit(s) to be signed off on in accordance with our DCO. Thanks! It also needs to be updated since it now has conflicts. |
Contributor
|
Requires DCO sign off still to be considered |
Contributor
|
@dilyanpalauzov: Have you progressed on your PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a feature is enabled by default
./configure --helpshould print '--disable-feature' and the called concludes from this output that the feature is enabled by default, even if the text after '--disable-feature' doesn't state this explicitly.Likewise, if a feature is disabled by default
./configure --helpshould print '--enable-feature' without stating, that the default is no.