Fix races in sasl_{client,server}_init()#845
Open
mistotebe wants to merge 1 commit intocyrusimap:masterfrom
Open
Fix races in sasl_{client,server}_init()#845mistotebe wants to merge 1 commit intocyrusimap:masterfrom
mistotebe wants to merge 1 commit intocyrusimap:masterfrom
Conversation
Signed-off-by: Ondřej Kuzník <ondra@mistotebe.net>
Contributor
Author
|
It still mutates global_callbacks, presumably in a memory-safe (even if non-deterministic) way, not sure if that's a problem. Otherwise might have to move that code around and abuse the fact that the content of global_callbacks is not touched in |
Contributor
Author
|
@adamyi Have you had a chance to check whether this addresses your issue or there are still scenarios where this fails for you? |
Contributor
|
@GuidoKiener: What do you think about this PR? |
Open
hyc
approved these changes
Mar 22, 2025
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should address #584 (comment), @adamyi, can you confirm it works for you?
Admittedly a more complete overhaul of the
_init()/_close()functions is warranted but I don't have a good approach for that yet.