Replace Travis with GitHub Actions without fixing test failures#855
Open
flowerysong wants to merge 5 commits intocyrusimap:masterfrom
Open
Replace Travis with GitHub Actions without fixing test failures#855flowerysong wants to merge 5 commits intocyrusimap:masterfrom
flowerysong wants to merge 5 commits intocyrusimap:masterfrom
Conversation
mistotebe
requested changes
Jan 9, 2025
Contributor
mistotebe
left a comment
mistotebe
left a comment
There was a problem hiding this comment.
Hi @flowerysong thanks for the work, would you be able to move the channel binding commit and the SASLDB_FREEPATH commit into their own PRs? The rest look good to go in together.
hyc
requested changes
Mar 22, 2025
Contributor
hyc
left a comment
hyc
left a comment
There was a problem hiding this comment.
Still waiting for the non-relevant changes to be split out of this PR.
hyc
reviewed
Mar 22, 2025
hyc
reviewed
Mar 22, 2025
Signed-off-by: Paul Arthur <paul.arthur@flowerysong.com>
SASL_PATH has no effect since 79827fb Signed-off-by: Paul Arthur <paul.arthur@flowerysong.com>
Makes the tests accurate but failing, since enabling SASL_SEC_NONSTD_CBIND doesn't actually work. Signed-off-by: Paul Arthur <paul.arthur@flowerysong.com>
Signed-off-by: Paul Arthur <paul.arthur@flowerysong.com>
Signed-off-by: Paul Arthur <paul.arthur@flowerysong.com>
flowerysong
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs the automated test suite using GHA. You can see it in action at https://github.com/flowerysong/cyrus-sasl/actions
Related: #852, #853, #854 (macOS uses NDBM for the PLAIN tests), #882
Closes #822.
Closes #747.