Check if div has content before indexing#24
Open
7o7omootsqwn wants to merge 1 commit intocysouw:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your work on
pandoc-ling.This commit just adds a guard in the function
processDivwhich checks that aDivhas content inside it before indexing into the content array. This makes the filter compatible withDivs that have no content inside them, which are supported by pandoc's model (though a bit of a strange corner case), and which I sometimes use in my own filters as placeholders forBlocklike elements which I calculate elsewhere then substitute into the document, e.g.With the current code, if
pandoc-lingis run before this substitution occurs, it attempts to index into theDiv's content and fails.