Skip to content

Replace create_empty_hcs_zarr with iohub's create_empty_plate#215

Open
tayllatheodoro wants to merge 3 commits intomainfrom
replace-create-empty-hcs-zarr-with-create-empty-plate
Open

Replace create_empty_hcs_zarr with iohub's create_empty_plate#215
tayllatheodoro wants to merge 3 commits intomainfrom
replace-create-empty-hcs-zarr-with-create-empty-plate

Conversation

@tayllatheodoro
Copy link
Collaborator

@tayllatheodoro tayllatheodoro commented Mar 12, 2026

Summary

  • Replace the local create_empty_hcs_zarr utility with create_empty_plate from iohub.ngff.utils in stabilize.py
  • Removes the now-unused import of create_empty_hcs_zarr from biahub.cli.utils

Test plan

  • Verify stabilization pipeline runs correctly with the updated function call

🤖 Generated with Claude Code

tayllatheodoro and others added 2 commits March 12, 2026 11:43
Use iohub's built-in `create_empty_plate` utility instead of the local
`create_empty_hcs_zarr` wrapper in stabilize.py.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@tayllatheodoro tayllatheodoro requested a review from srivarra March 12, 2026 18:52
Copy link
Collaborator

@srivarra srivarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should go through and replace other instances of this function (I see a few extra places where this is used), and merge this after #214.

Comment on lines 25 to 31
from biahub.cli.utils import (
copy_n_paste_czyx,
create_empty_hcs_zarr,
estimate_resources,
process_single_position_v2,
yaml_to_model,
)
from biahub.register import convert_transform_to_ants
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we go through and remove create_empty_hcs_zarr across the package, and the function itself?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i just did except the functions that call from waveorder because the metadata is different

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is the metadata different? I'm not sure I'm following here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants