Adding filter_min_consecutive_fractions function and updating documentation. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt versus all function. Also modified the original function to take into account multiple covariates (replicate, condition, etc).
… names across functions
mffrank
requested changes
Jul 10, 2025
Collaborator
mffrank
left a comment
mffrank
left a comment
There was a problem hiding this comment.
Looks good, but let's discuss the visual_qc_condition_subsets function
grassp/preprocessing/simple.py
Outdated
| return max_lengths | ||
|
|
||
|
|
||
| def visual_qc_condition_subsets( |
Collaborator
There was a problem hiding this comment.
I'm not sure this function is generic enough. Also it should probably go into plotting. Can you take it out of this PR for now? (dont' forget the imports)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As detailed above.