Skip to content

Update macros in documentation - #39

Merged
d-morrison merged 6 commits into
mainfrom
d-morrison-patch-1
May 13, 2026
Merged

d-morrison merged 6 commits into
mainfrom
d-morrison-patch-1

Conversation

@d-morrison

Copy link
Copy Markdown
Owner

This pull request introduces a new macro definition to the macros.qmd file. The main change is the addition of a shorthand macro for the log-rate parameter, improving code clarity and consistency.

Macro additions:

  • Added a new macro definition \lograte as an alias for \lincomp, which can now be used in place of writing \lincomp directly.

Copilot AI review requested due to automatic review settings May 12, 2026 00:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a shorthand MathJax/LaTeX macro to the project’s macro set to improve consistency when referring to the log-rate parameter.

Changes:

  • Added \lograte as an alias for \lincomp in macros.qmd.

Comment thread macros.qmd
@d-morrison

Copy link
Copy Markdown
Owner Author

@copilot apply changes based on the comments in this thread

Agent-Logs-Url: https://github.com/d-morrison/macros/sessions/feb2bd1c-df50-4c56-bafc-1372db173a56

Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>

Copilot AI commented May 12, 2026

Copy link
Copy Markdown
Contributor

@copilot apply changes based on the comments in this thread

Addressed in 889bb1d by adding the missing \\lograte entry to interpretations.tsv. I also reproduced the render failure before the change and confirmed quarto render macros-table.qmd succeeds afterward.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 13, 2026 02:46
@d-morrison

Copy link
Copy Markdown
Owner Author

@copilot also add notation for conditional survival, kappa, matching d-morrison/rme#709

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread macros.qmd Outdated
\providecommand{\doddsinvf}[1]{{\oddsinv}'\cb{#1}}
\providecommand{\dinvoddsf}[1]{{\invodds}'\cb{#1}}
\def\rate{{\lambda}}
% NOTE: keep interpretations.tsv in sync with new macro names; \lograte needs a matching interpretation row.
Agent-Logs-Url: https://github.com/d-morrison/macros/sessions/efa4f2c2-d0c8-434d-b16a-b86b07ae3c4f

Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>

Copilot AI commented May 13, 2026

Copy link
Copy Markdown
Contributor

@copilot also add notation for conditional survival, kappa, matching d-morrison/rme#709

Added in 27b270f. The changes include:

  • \k for kappa (κ) - conditional survival probability
  • \hk and \hkappa for estimated conditional survival (κ̂)
  • Corresponding interpretation entries in interpretations.tsv

These match the notation used in PR 709 where κ(t) = Pr(T > t | T ≥ t) = 1 - λ(t).

@d-morrison

Copy link
Copy Markdown
Owner Author

Copilot AI review requested due to automatic review settings May 13, 2026 05:45
@d-morrison
d-morrison removed the request for review from Copilot May 13, 2026 05:45

Copilot AI commented May 13, 2026

Copy link
Copy Markdown
Contributor

@copilot apply changes based on the comments in this thread and fix https://github.com/d-morrison/macros/actions/runs/25775...

Fixed in 72f373d. Removed the TeX comment that was breaking the parser. CI run #103 now passes successfully - all rendering steps completed without errors.

@d-morrison

Copy link
Copy Markdown
Owner Author

add macros \cs and \condsurv that should evaluate to \kappa. These macros are interpreted as conditional survival probabilities $\Pr(T&gt;t|T\ge t)$ @copilot

Agent-Logs-Url: https://github.com/d-morrison/macros/sessions/09dbc6ee-ca5e-48ab-becf-7b300d1af909

Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 13, 2026 06:14
@d-morrison
d-morrison removed the request for review from Copilot May 13, 2026 06:14

Copilot AI commented May 13, 2026

Copy link
Copy Markdown
Contributor

add macros \cs and \condsurv that should evaluate to \kappa. These macros are interpreted as conditional survival probabilities $\Pr(T&gt;t|T\ge t)$ @copilot

Added in a065b0e. The macros \cs and \condsurv now evaluate to \kappa and are interpreted as conditional survival probability Pr(T>t|T≥t). CI run #104 passed successfully.

@d-morrison
d-morrison merged commit 8659bba into main May 13, 2026
1 check passed
@d-morrison
d-morrison deleted the d-morrison-patch-1 branch May 13, 2026 08:44
@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants