Shorten survival-estimator macro names (hsurvkmf -> hskmf, etc.) - #77
Merged
Merged
Conversation
Renames \hsurvemp/\hsurvkm/\hsurvnaa (and their f-suffixed function forms) to \hsemp/\hskm/\hsnaa, dropping the redundant "urv" now that the \hs prefix combined with the estimator subscript is unambiguous.
d-morrison
pushed a commit
to d-morrison/rme
that referenced
this pull request
Jul 3, 2026
Follows the rename in d-morrison/macros#77: \hsurvkmf -> \hskmf, \hsurvnaaf -> \hsnaaf, and the corresponding zero-arg/emp forms. Bumps latex-macros to pick up the rename.
Contributor
There was a problem hiding this comment.
Pull request overview
Renames the survival-estimator “hat-S” macros to shorter, more ergonomic names while keeping their underlying composition unchanged (still built on \hsurv with estimator-label subscripts), and updates the macro interpretation registry accordingly.
Changes:
- Renamed
\hsurvemp,\hsurvkm,\hsurvnaa→\hsemp,\hskm,\hsnaa. - Renamed function-call variants
\hsurvempf,\hsurvkmf,\hsurvnaaf→\hsempf,\hskmf,\hsnaaf. - Updated
interpretations.tsvto match the new macro names (no missing stale entries found in-repo).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| macros.qmd | Renames the survival-estimator macros and their function-call forms. |
| interpretations.tsv | Updates the macro interpretation rows to match the renamed commands. |
Contributor
|
This was referenced Jul 4, 2026
d-morrison
added a commit
to d-morrison/rme
that referenced
this pull request
Jul 4, 2026
* Use new survival-estimator macros for KM/Nelson-Aalen notation
Replace ad hoc \hat{S}_{KM}(t)/\hat{S}_{NA}(t)-style LaTeX with the
\hsurvkmf{}/\hsurvnaaf{} macros added in d-morrison/macros#76 (issue
d-morrison/macros#75), across the KM/NA estimator definitions,
derivations, exercises, and the competing-risks and midterm-review
chapters. Bumps the latex-macros submodule to pick up the new macros.
* Point latex-macros submodule at merged main (macros#76)
Re-points from the macros#76 branch commit to main now that it has
merged.
* Rename to shortened survival-estimator macros (hskmf, hsnaaf, etc.)
Follows the rename in d-morrison/macros#77: \hsurvkmf -> \hskmf,
\hsurvnaaf -> \hsnaaf, and the corresponding zero-arg/emp forms.
Bumps latex-macros to pick up the rename.
* Point latex-macros submodule at merged main (macros#77)
Re-points from the macros#77 branch commit to main now that it has
merged.
---------
Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\hsurvemp/\hsurvkm/\hsurvnaa(and theirf-suffixed function-call forms) to\hsemp/\hskm/\hsnaa.interpretations.tsventries. Pure rename — no change in semantics or composition (still built on the existing\hsurvhat-S macro).Test plan
interpretations.tsventries via the same standalone R check used in Add survival-function estimator macros (empirical, KM, Nelson-Aalen) #76.quarto render— not run locally (same sandbox limitation as Add survival-function estimator macros (empirical, KM, Nelson-Aalen) #76); relying on this repo'sbuild-deployCI (which renders the whole site + both PDF demos) to validate, as it did for Add survival-function estimator macros (empirical, KM, Nelson-Aalen) #76.This is a rename-only change; downstream PRs d-morrison/rme#978 and ucdavis/epi204#358 will be updated to use the new names once this merges.
Generated by Claude Code