Revert now-unneeded DT install#85
Conversation
#82 added DT to the render-dependency installs to fix macros-table.qmd's DT::datatable() render. Since the macros submodule's .qmd files are no longer rendered (the project render list now excludes macros/), nothing in the rendered site uses DT, so installing it just adds an unused package to every render workflow (and every downstream book). Remove it to keep the template lean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Claude finished @d-morrison's task in 50s —— View job Code Review: PR #85 — Revert now-unneeded DT install
Clean PR. Approve. VerificationSearched all
Workflow changesAll three workflow files are touched consistently:
ReasoningThe causal chain in the PR description is sound:
No issues found. |
There was a problem hiding this comment.
Pull request overview
This PR removes the DT R package from CI render dependency installs now that the macros/ submodule’s .qmd files are no longer rendered as standalone pages and there are no remaining DT usages in the rendered site.
Changes:
- Remove
any::DTfrom the R package install list in the publish workflow. - Remove
any::DTfrom the R package install list in the PR preview workflow. - Remove
DTfrom the Copilot setup workflow’sinstall.packages()list.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/publish.yml |
Drops DT from publish-time R dependencies to reduce unnecessary installs. |
.github/workflows/preview.yml |
Drops DT from preview-time R dependencies to reduce unnecessary installs. |
.github/workflows/copilot-setup-steps.yml |
Drops DT from Copilot environment setup to match current render needs. |
|
Why
#82 added
DTto the render-dependency installs (publish.yml,preview.yml,copilot-setup-steps.yml) to fixmacros-table.qmd'sDT::datatable()render.Since #84 the project no longer renders the
macrossubmodule's.qmdfiles, and nothing in the rendered site usesDT. So theDTinstall is now dead weight — an unused package installed on every render (and inherited by every downstream book). This removes it.Changes
publish.yml/preview.yml— dropany::DTfrom thesetup-r-dependenciespackage list.copilot-setup-steps.yml— drop"DT"from theinstall.packages()list.Test plan
Quarto Publishonmainstays green.🤖 Generated with Claude Code