Skip to content

Revert now-unneeded DT install#85

Merged
d-morrison merged 1 commit into
mainfrom
revert/unneeded-DT-install
May 26, 2026
Merged

Revert now-unneeded DT install#85
d-morrison merged 1 commit into
mainfrom
revert/unneeded-DT-install

Conversation

@d-morrison

Copy link
Copy Markdown
Owner

Why

#82 added DT to the render-dependency installs (publish.yml, preview.yml, copilot-setup-steps.yml) to fix macros-table.qmd's DT::datatable() render.

Since #84 the project no longer renders the macros submodule's .qmd files, and nothing in the rendered site uses DT. So the DT install is now dead weight — an unused package installed on every render (and inherited by every downstream book). This removes it.

Changes

  • publish.yml / preview.yml — drop any::DT from the setup-r-dependencies package list.
  • copilot-setup-steps.yml — drop "DT" from the install.packages() list.

Test plan

  • This PR's preview render still succeeds (the rendered pages — chapters + index — don't use DT).
  • After merge, Quarto Publish on main stays green.

🤖 Generated with Claude Code

#82 added DT to the render-dependency installs to fix macros-table.qmd's
DT::datatable() render. Since the macros submodule's .qmd files are no
longer rendered (the project render list now excludes macros/), nothing in
the rendered site uses DT, so installing it just adds an unused package to
every render workflow (and every downstream book). Remove it to keep the
template lean.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 26, 2026 17:13
@claude

claude Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

Claude finished @d-morrison's task in 50s —— View job


Code Review: PR #85 — Revert now-unneeded DT install

  • Gather context and read changed files
  • Verify DT is not used anywhere in the rendered site
  • Review workflow changes
  • Post final review

Clean PR. Approve.

Verification

Searched all .qmd, .R, and .Rmd files for DT::, library(DT), and require(DT). The only hit outside macros/ is a comment in _quarto-website.yml (line 12) explaining why macros/ is excluded from rendering — that comment remains accurate and doesn't need to change.

DT is not in DESCRIPTION, so there's no package-level dependency to clean up either.

Workflow changes

All three workflow files are touched consistently:

  • publish.yml / preview.ymlany::DT dropped from the r-lib/actions/setup-r-dependencies package list. The remaining set (knitr, rmarkdown, tibble) correctly covers what the rendered site actually uses.
  • copilot-setup-steps.yml"DT" removed from the install.packages() call, leaving c("lintr", "rmarkdown"). Correct.

Reasoning

The causal chain in the PR description is sound:

  • macros-table.qmd (in the macros/ submodule) was the sole consumer of DT::datatable().
  • PR Don't render the macros submodule's .qmd files directly #84 excluded macros/ from rendering via !macros/ in _quarto-website.yml.
  • Nothing in the rendered site uses DT, so installing it on every render (and in every downstream book) is pure dead weight.

No issues found.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the DT R package from CI render dependency installs now that the macros/ submodule’s .qmd files are no longer rendered as standalone pages and there are no remaining DT usages in the rendered site.

Changes:

  • Remove any::DT from the R package install list in the publish workflow.
  • Remove any::DT from the R package install list in the PR preview workflow.
  • Remove DT from the Copilot setup workflow’s install.packages() list.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/publish.yml Drops DT from publish-time R dependencies to reduce unnecessary installs.
.github/workflows/preview.yml Drops DT from preview-time R dependencies to reduce unnecessary installs.
.github/workflows/copilot-setup-steps.yml Drops DT from Copilot environment setup to match current render needs.

@d-morrison d-morrison merged commit ea19c01 into main May 26, 2026
11 checks passed
@d-morrison d-morrison deleted the revert/unneeded-DT-install branch May 26, 2026 17:21
@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-05-26 10:27 PDT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants