Modularize the bus. Add example of usage. #38
+625
−384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I will break this out into a new branch.
jimktrains
commented
Jun 13, 2025
| @@ -75,8 +131,6 @@ impl XRegisters { | |||
| /// Create a new `XRegisters` object. | |||
| pub fn new() -> Self { | |||
| let mut xregs = [0; REGISTERS_COUNT]; | |||
| // The stack pointer is set in the default maximum memory size + the start address of dram. | |||
| xregs[2] = DRAM_BASE + DRAM_SIZE; | |||
There was a problem hiding this comment.
Since the stack is based on where the system wants it, we don't know where we would have to initialize this, and it needs to be done elsewhere. When the DRAM is initialized on the bus, I do set the stack pointer to the end of ram.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks the bus apart and allows it to be built up programmatically.