Conversation
d0ugal
force-pushed
the
fix-metric-label-order
branch
from
b84bd81 to
9860575
Compare
Fix label mapping mismatch where collection metrics expected 'repo'
label but were receiving 'name' label. This was causing panics:
panic: label name "repo" missing in label map
The metrics definitions in ghcr_registry.go specify:
- CollectionFailedCounter: []string{"repo", "interval"}
- CollectionSuccessCounter: []string{"repo", "interval"}
- CollectionIntervalGauge: []string{"repo", "interval"}
- CollectionDurationGauge: []string{"repo", "interval"}
- CollectionTimestampGauge: []string{"repo", "interval"}
But the collector was using 'name' instead of 'repo' in the labels.
This highlights the need for better integration tests that would
catch label mapping mismatches before deployment.
d0ugal
force-pushed
the
fix-metric-label-order
branch
from
9860575 to
fb84718
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.