fix(workflows): fix workflow syntax errors, revert Alpine, and enable PR builds#259
Merged
fix(workflows): fix workflow syntax errors, revert Alpine, and enable PR builds#259
Conversation
… PR builds - Change default-branch to target-branch for release-please-action@v4 - Remove invalid continue-on-error input from build-push-action@v6 - Revert Alpine from 3.23.0 to 3.22.2 to fix ARM64 qemu emulation issues - Change golang:1.25.5-alpine to golang:1.25.4-alpine (uses Alpine 3.22.2) - Add pull_request trigger to dev-build workflow - Only push images on push events, not PRs - Skip GHCR login on PRs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes workflow syntax errors, Alpine 3.23.0 qemu emulation issues, and enables PR builds:
Fixed workflow syntax errors:
default-branchtotarget-branchforgoogleapis/release-please-action@v4continue-on-errorinput fromdocker/build-push-action@v6Fixed Alpine 3.23.0 qemu emulation issues:
alpine:3.23.0toalpine:3.22.2golang:1.25.5-alpinetogolang:1.25.4-alpine(uses Alpine 3.22.2)Enhanced dev-build workflow:
pull_requesttrigger to build on PRsErrors Fixed
Testing
Once merged, workflows should complete successfully and PRs will validate builds without pushing images.