Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TF] Implement TrainCallback on batch #2202

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adtygan
Copy link
Contributor

@adtygan adtygan commented Jul 14, 2022

Description of changes:

1.Updated class definition in https://github.com/d2l-ai/d2l-en/blob/master/chapter_appendix-tools-for-deep-learning/utils.md
2. However, when I ran d2lbook build lib, it removed imports in d2l/mxnet.py, d2l/torch.py and d2l/tensorflow.py. Therefore, I manually updated the class definition in d2l/tensorflow.py directly.

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.

@d2l-bot
Copy link
Member

d2l-bot commented Jul 14, 2022

Job d2l-en/PR-2202/1 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2202/

@adtygan
Copy link
Contributor Author

adtygan commented Jul 14, 2022

The CI logs here - http://ci.d2l.ai/blue/organizations/jenkins/d2l-en/detail/PR-2202/1/pipeline/ show that the notebooks were re-run but still the plots don't seem to be updated. As seen here http://preview.d2l.ai/d2l-en/PR-2202/chapter_optimization/lr-scheduler.html , the Tensorflow plot is still smooth unlike other two. I'm not sure where the error is.

@d2l-bot
Copy link
Member

d2l-bot commented Aug 29, 2022

Job d2l-en/PR-2202/2 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2202/

@d2l-bot
Copy link
Member

d2l-bot commented Aug 29, 2022

Job d2l-en/PR-2202/3 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2202/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants