fix: retry Magick decoding without the extension hint - #2446
Open
CNDY1390 wants to merge 1 commit into
Open
Conversation
CNDY1390
marked this pull request as ready for review
September 4, 2026 21:47
CNDY1390
marked this pull request as draft
September 4, 2026 22:05
CNDY1390
force-pushed
the
fix/reuse-detected-magick-format
branch
from
September 5, 2026 13:02
3324a3b to
04dcbb6
Compare
CNDY1390
marked this pull request as ready for review
September 5, 2026 14:42
CNDY1390
changed the title
CNDY1390
force-pushed
the
fix/reuse-detected-magick-format
branch
2 times, most recently
from
September 6, 2026 09:08
bba9fca to
b05f7b3
Compare
CNDY1390
force-pushed
the
fix/reuse-detected-magick-format
branch
from
September 6, 2026 17:02
b05f7b3 to
c5aad18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🟢 Summary
Addresses #2403.
Valid PNG and multi-frame GIF files named
.tifcan pass metadata probing but fail during decoding because Magick.NET's filename-basedReadAsyncsupplies a TIFF format hint.This keeps the normal read first. On an eligible decoding error, with no explicit format override, it retries once through a Stream without that hint. The change covers single-image, multi-frame and QuickDecode reads; saving uses the same decode path.
Btw, although this issue was opened in v9 era, it is still reproducible in v10(10.0.6.906).
Validation
I manually tested the artifact from GH Actions run.
🟢 Contributor License Agreement (CLA)
By submitting this pull request, I confirm that: