Let screen wake touches pass through#225
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ScreenWakeActivitynon-touchable so the transparent wake holder does not consume the first tap or swipe after waking the screendispatchTouchEvent()handler that finished the activity while returning the event as handledTest plan
./gradlew :app:testFossDebugUnitTest --tests eu.darken.bluemusic.monitor.core.screenwake.ScreenWakeActivityTest./gradlew :app:testGplayDebugUnitTest --tests eu.darken.bluemusic.monitor.core.screenwake.ScreenWakeActivityTestManual verification note
On a Pixel/Android lockscreen, the expected behavior is now: KeepAwake wakes the screen, and the first tap/swipe should reach the lockscreen or launched app instead of only dismissing BlueMusic's transparent wake activity.