Repository navigation
Device: Remember adaptive audio noise level after reconnecting - #765
Merged
Merged
Conversation
AdaptiveAudioNoise (AAP 0x2E) is push-only and dropped from AapPodState on every disconnect, but unlike AllowOffOption/ListeningModeCycle it was never wired into the existing profile-learned-settings persistence pattern, so the UI reset to whatever the device happened to push after a reconnect instead of the user's last chosen level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The Adaptive Audio "ambient noise" slider value is now remembered when your AirPods disconnect and reconnect. Previously the app would show the default level again after a reconnect until you adjusted the slider manually.
Technical Context
AppleDeviceProfile, update the persister to track it, and add the same profile fallback toPodDevice.adaptiveAudioNoise.PodDevice.adaptiveAudioNoiseunconditionally and will pick up the restored value automatically.null, so no migration is needed for existing stored profiles.Relates to CAPOD-6