feat: add periodic device activity reporter#13
Merged
Conversation
Logs active-device counts grouped by client version every 5 minutes (1h and 24h windows). Active = lastSeen within window OR currently connected via WebSocket. Adds activeDeviceKeys() snapshot on ConnectionRegistry to surface live connections that haven't recently pinged lastSeen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeviceActivityReporterbackground job that logs active-device counts grouped by client version every 5 minutes, with both 1h and 24h windows.lastSeenwithin the window OR a live WebSocket connection. NewConnectionRegistry.activeDeviceKeys()snapshot exposes the latter.Appconstructs it eagerly so the periodic job starts at boot.Test plan
DeviceActivityReporterTest— window membership, format/percent, unknown bucket, sanitizer truncation, sanitized-equivalent groupingConnectionRegistryTest—activeDeviceKeyssnapshot on register/unregisterdevice-stats: 1h total=… 24h total=…shows up in operator logs