Fix canary release target_commitish on gh release calls#29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update rolling canary pre-releasestep withHTTP 422 Release.target_commitish is invalid--target "$TAG"passed the literal stringcanaryas target_commitish, which gh interprets as a branch namegh release createto--target "$SHA" --verify-tagand drop--targetfromgh release editsince the canary tag is already moved to that commit by the preceding stepCurrent main state after the failed first run
:canaryand:sha-469e167— publishedcanary— points at 469e167canary— not yet created (this PR's merge run will create it)Test plan
gh release createshould now succeed and create the rolling pre-release