Improve search bar appearance with icon and clear button#318
Merged
Conversation
Replace plain OutlinedTextField search bars with a shared SearchTextField composable that has a leading search icon, trailing clear button, pill shape, and tinted container. Standardize toggle-off behavior to clear the search query on all three screens (Apps, Permissions, Watcher) so the list is never silently filtered when the search bar is hidden.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Search bars on the apps, permissions, and watcher screens now have a polished appearance with a leading search icon, a trailing clear button (visible when text is entered), a pill shape, and a tinted background. Dismissing the search bar now consistently clears the search query on all screens, so the list is never silently filtered.
Technical Context
WatcherDashboardScreeninto a sharedSearchTextFieldcomposable incommon/compose/— no new design, just deduplicationAppsScreenwas missingAnimatedVisibilityfor the search bar and didn't clear the query on toggle-off; both are now fixed to match the other screens