Permissions: Align filter and sort UI with apps list#319
Merged
Conversation
Replace separate filter/sort AlertDialogs with unified ModalBottomSheet, add grouped filter chips with OR-within-group/AND-between-groups logic, add filter icon with badge dot in TopAppBar, add help buttons to both apps and permissions filter sheets, remove upgrade star from toolbars, make expand/collapse menu contextual, add @SerialName to all serialized enums, add serialization and filter logic tests.
Set LocalMinimumInteractiveComponentSize to 40dp for filter chips (default 48dp added too much vertical gap). Add default and active-filter preview composables for both bottom sheets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The permissions list now uses the same filter and sort UI as the apps list β a unified bottom sheet instead of separate dialogs. Filter options are grouped into "Source" and "Type" categories with intuitive combination logic: filters within a group are combined with OR, groups are combined with AND.
Both the apps and permissions filter sheets now include a help button explaining the icons and tags shown in each list. The upgrade star has been removed from both toolbars, and the expand/collapse menu in the permissions list now shows only the relevant action based on current state.
Filter and sort option enums now have hardcoded serialization names to prevent silent breakage from future refactoring.
Technical Context
Groupenum onFilter,matches()withgroupBy/all/anyMultiChoiceFilterDialog/SingleChoiceSortDialogare no longer used by the permissions list screen (still used by other screens)@SerialNameannotations match current enum names β no migration needed, purely forward-protectionlistDatagroup items β no new ViewModel state needed