General: Refresh Play Store screenshots and add Watcher screen#355
Merged
Conversation
Drop the Overview Dark and Settings screenshots, add a new Watcher Dashboard screenshot, and replace the stale 2022 PNGs with freshly generated descriptive-named files. Source changes: - New WatcherDashboardPreviewData with 5 reports (WhatsApp/Signal/Spotify/Chrome/DuckDuckGo) covering UPDATE, INSTALL, GRANT_CHANGE, and REMOVED event types. Uses fixed timestamps so regenerations are deterministic. - WatcherDashboardScreen inline preview now reuses the shared PreviewData instead of duplicating state. - ScreenshotContent.WithBottomBar rewritten from Box overlay to Column-with-weight, matching production layout. Adds the missing 4th tab (Watcher) with a sample badge of '3' so existing tab screenshots also reflect the real production bar. - PlayStoreScreenshots and PlayStoreLocales pruned of OverviewDark, SettingsIndex, and the now-dead PlayStoreLocalesDark annotation. Pipeline scripts: - copy_screenshots.sh SCREEN_MAP rewritten for the new 6-entry screen set. - generate_screenshots.sh: dropped the dark-annotation generation block, fixed composable count (7 -> 6), and added a BATCH_SIZE_EXPLICIT flag so '--smoke --batch-size N' actually honors the override (previously the smoke branch always overwrote BATCH_SIZE and OOM'd PermissionDetails). Assets: - Removed 10 stale screenshot1.png-screenshot10.png files in en-US. - Generated fresh 1_overview_light.png through 6_watcher.png in en-US plus the 5 other smoke locales (de-DE, ja-JP, ar, zh-CN, pt-BR) as a no-op-equivalent side-effect. - README.md now embeds 6 relative-path images so previews render in PRs as well as on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Refreshed the Play Store / GitHub README screenshots:
Technical Context
WatcherDashboardPreviewData(new): 5 reports covering all fourWatcherEventTypevalues (UPDATE, INSTALL, GRANT_CHANGE, REMOVED) with realistic app names lifted fromAppsPreviewDatafor cross-screenshot consistency. Uses fixed epoch-millis timestamps (noSystem.currentTimeMillis()) so screenshot regenerations are deterministic instead of churning every run.WatcherDashboardScreeninline preview now reuses the new sharedWatcherDashboardPreviewData.loadedState()instead of duplicating its own state β single source of truth between IDE preview and Play Store screenshot.ScreenshotContent.WithBottomBarrewritten fromBoxoverlay toColumn { Box(weight=1f) { content }; NavigationBar { β¦ } }matching the productionMainScreenlayout. Previously the bar was overlaid on top of the content (would cover the Watcher FAB and bottom rows of lists). Also bumped from 3 to 4 tabs to match production, with a sampleBadge { Text("3") }on the Watcher tab so the shipped screenshots reflect the real bottom bar users see.@PlayStoreLocalesDarkannotation class and its generator block ingenerate_screenshots.sh. Updated composable count from 7 to 6. Added aBATCH_SIZE_EXPLICITflag so--smoke --batch-size Nactually honors the override β without it, smoke mode forces all 6 locales into a single batch and PermissionDetails OOMs in layoutlib.copy_screenshots.shSCREEN_MAP rebuilt for the new 6-entry screen set.screenshot1.pngβ¦screenshot10.pngfiles removed fromen-US. Theen-USdirectory plus the 5 smoke-incidental locales (de-DE, ja-JP, ar, zh-CN, pt-BR) now contain the new descriptive PNGs (1_overview_light.pngthrough6_watcher.png). Other 33 locales still hold no screenshots β full multi-locale regeneration is left for a separate ~20-minute run.Review guidance
fastlane/metadata/android/en-US/images/phoneScreenshots/are the easiest way to sanity-check the output.WithBottomBarrewrite affects every existing tab screenshot (Overview/Apps/Permissions) β they all now show the corrected 4-tab bar with the Watcher badge, so binary diffs there are expected.