General: Track only smoke locales for Play Store screenshots#363
Merged
Conversation
Mirror the d4rken-org/capod#585 pattern: gitignore Play Store phone screenshots for non-smoke locales, keeping only the 6 smoke locales (en-US, de-DE, ja-JP, ar, zh-CN, pt-BR) tracked. The smoke set matches SMOKE_LOCALES in fastlane/generate_screenshots.sh. Future screenshot refreshes only diff 6 locales x 6 screens = 36 PNGs instead of 234, so reviews stay readable. Full localization is generated + uploaded on demand via 'bundle exec fastlane screenshots_only'; Fastlane skips locales with no local files, so absent locales keep whatever Play Store currently has. Also: fail generate_screenshots.sh non-zero on PNG count mismatch (was a soft warning), fix the stale '39 x 7 screens' comment in build-commands.md (it's 39 x 6), and add .claude/rules/screenshots.md describing the regen + upload + working-tree cleanup workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Play Store phone screenshots are now tracked in git for only the 6 smoke locales (
en-US,de-DE,ja-JP,ar,zh-CN,pt-BR). The remaining 33 locales are gitignored and regenerated on demand. No user-facing change — Play Store retains previously-uploaded screenshots for locales not pushed in the next upload.Technical Context
d4rken-org/capod#585pattern. The smoke set matchesSMOKE_LOCALESinfastlane/generate_screenshots.sh..gitignorerule usesfastlane/metadata/android/*/images/phoneScreenshots/*.pngfollowed by 6!-include rules.en-US/images/icon.pngandfeatureGraphic.pngsit one level higher thanphoneScreenshots/so they are unaffected.app/src/screenshotTestGplayDebug/reference/ignore is broadened toapp/src/screenshotTest*/reference/so any future flavor variant (e.g. FOSS) gets covered.fastlane/generate_screenshots.shnow exits non-zero on a PNG count mismatch instead of just printing a warning, so partial renders fail loudly before the copy/upload steps..claude/rules/screenshots.mddocuments the manual regen + upload workflow, including the post-uploadgit clean -fdX fastlane/metadata/androidcleanup (removes only ignored files) and thegit checkout -- fastlane/metadata/android/{ckb-IR,ku-TR}restoration afterremove_unsupported_languages.shruns.pt-BRandzh-CN's1_overview_light.png) come from a deterministic re-render and are visually identical to the previous content.Review note
The retention assumption — Fastlane skips locales with no local files, so absent locales keep their Play Store screenshots — is current Fastlane uploader behavior, not a Play Store guarantee. After the next smoke-only upload, the screenshots.md doc instructs a one-time Play Console spot-check on a non-smoke locale (e.g.
fr-FR) to validate.