pool: use SSLTrustManagerWithHostnameChecking to initialize CAnL #7943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: JVM uses X509ExtendedTrustManager class to validate the host certificate. The CANL provides two implementations of TrustManagers: SSLTrustManagerWithHostnameChecking, which extends X509ExtendedTrustManager, and SSLTrustManager, which extends X509TrustManager. In case of the latter one, JDK will wrap with a AbstractTrustManagerWrapper implementation, which enforces additional checks, which are not desired. Modification: Update RemoteHttpTransferService to use SSLTrustManagerWithHostnameChecking to initialize CAnL for remote endpoint certificate validation. Result: TPC-HTTP remote endpoint validation performed based on local trusted store and host name. Fixes: #7927 Acked-by: Karen Hoyos Target: master, 11.1, 11.0, 10.2 Require-book: no Require-notes: yes (cherry picked from commit c483a3c) Signed-off-by: Tigran Mkrtchyan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
JVM uses X509ExtendedTrustManager class to validate the host certificate. The CANL provides two implementations of TrustManagers: SSLTrustManagerWithHostnameChecking, which extends X509ExtendedTrustManager, and SSLTrustManager, which extends X509TrustManager. In case of the latter one, JDK will wrap with a AbstractTrustManagerWrapper implementation, which enforces additional checks, which are not desired.
Modification:
Update RemoteHttpTransferService to use SSLTrustManagerWithHostnameChecking to initialize CAnL for remote endpoint certificate validation.
Result:
TPC-HTTP remote endpoint validation performed based on local trusted store and host name.
Fixes: #7927
Acked-by: Karen Hoyos
Target: master, 11.1, 11.0, 10.2
Require-book: no
Require-notes: yes
(cherry picked from commit c483a3c)