test: Fix tests on Java 21 or newer; replace InetAddress mocking code #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kofemann
reviewed
Jun 17, 2025
core/src/test/java/org/dcache/testutils/InetAddressMockery.java
Outdated
Show resolved
Hide resolved
kofemann
reviewed
Jun 17, 2025
core/src/test/java/org/dcache/testutils/InetAddressMockery.java
Outdated
Show resolved
Hide resolved
kofemann
requested changes
Jun 17, 2025
Member
kofemann
left a comment
kofemann
left a comment
There was a problem hiding this comment.
Thanks for looking at this. The proposed solution seems overengineered. Please consider an alternative approach.
Some unit tests work with fake ("mocked") InetAddress objects, which are
currently assembled via mockito. With Java 21 and newer, this is no
longer possible.
Replace the mocking code with direct calls to
InetAddress.getByAddress(String,byte[]).
Fixes dCache#144
Signed-off-by: Christian Kohlschütter <[email protected]>
kohlschuetter
force-pushed
the
ck/issue/144
branch
from
7388dee to
7d7a190
Compare
kohlschuetter
changed the title
Member
|
Thanks for the contribution 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some unit tests work with fake ("mocked") InetAddress objects, which are currently assembled via mockito. With Java 21 and newer, this is no longer possible.
Replace the mocking code with a new "InetAddressMockery" class that can provide real Inet4Address objects by means of Java object deserialization.
Fixes #144