Skip to content

docs(footer): add Footer component documentation#1707

Merged
junghyeonsu merged 2 commits into
devfrom
junghyeonsu/footer-block-preview
Jun 23, 2026
Merged

docs(footer): add Footer component documentation#1707
junghyeonsu merged 2 commits into
devfrom
junghyeonsu/footer-block-preview

Conversation

@junghyeonsu

@junghyeonsu junghyeonsu commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

원본 PR #1687(@jus0k)의 Footer 컴포넌트 문서를 내부 브랜치로 이어받아 머지합니다.

fork PR이라 alpha docs 미리보기 CI(deploy-seed-design-docs-alpha-pages)가 pull_request 트리거 부재로 동작하지 않아, 미리보기 배포와 머지를 위해 내부 브랜치로 옮겼습니다.

커밋 author는 원작자(@jus0k)로 보존되어 있습니다.

Replaces #1687

Summary by CodeRabbit

  • Chores
    • Figma 이미지 캐시 관리 기능 개선으로 문서 빌드 시 특정 이미지의 캐시를 선택적으로 무시할 수 있도록 개선했습니다.

@changeset-bot

changeset-bot Bot commented Jun 23, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 89cf35b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f53f4e44-a6ae-4143-a89a-c6b0fec2dc32

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

GitHub Actions 워크플로우에 fresh-node-ids 입력을 추가하고, FIGMA_FRESH_NODE_IDS 환경변수를 통해 env.figmaFreshNodeIds 배열로 파싱합니다. fetchFigmaImageUrls 내 캐시 우회 조건을 shouldBypassCache(nodeId) 헬퍼로 일원화하여 노드 단위 캐시 우회가 가능해집니다.

Changes

Figma 노드 단위 캐시 우회 기능 추가

Layer / File(s) Summary
CI 입력값 및 환경변수 연결
.github/workflows/deploy-seed-design-docs-alpha-pages.yml, docs/app/env.ts
workflow_dispatchfresh-node-ids 입력을 추가하고 빌드 단계에 FIGMA_FRESH_NODE_IDS 환경변수로 전달하며, env.figmaFreshNodeIds로 콤마 분리·파싱하는 속성을 추가합니다.
캐시 우회 헬퍼 추가 및 적용
docs/components/figma-image/fetch-figma-image-urls.ts
shouldBypassCache(nodeId) 헬퍼를 신규 추가하고, 초기 캐시 조회 분기와 세마포어 재검증 필터 두 곳 모두에서 기존 env.figmaCacheDisabled 단일 조건을 이 헬퍼 호출로 교체합니다.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 노드 ID 하나하나, 캐시를 건너뛰어~
fresh-node-ids 입력, 워크플로우에 쏙!
환경변수 타고 달려, 배열로 탈바꿈 ✨
shouldBypassCache 헬퍼, 두 곳을 지켜요
토끼처럼 빠르게, 새 이미지 가져와라! 🖼️

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning PR 제목 '문서(footer): Footer 컴포넌트 설명서 추가'는 Footer 컴포넌트 문서 추가에만 관련되어 있지만, 실제 변경사항은 Figma 캐시 바이패스 기능 추가, 워크플로우 설정 변경, 환경변수 설정 등 훨씬 광범위합니다. PR 제목을 '캐시 바이패스 기능 추가 및 Figma 이미지 처리 개선' 또는 유사한 내용으로 변경하여 실제 주요 변경사항을 반영하도록 수정하세요.
Docstring Coverage ⚠️ Warning Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch junghyeonsu/footer-block-preview

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Alpha Preview (Docs)

@junghyeonsu junghyeonsu force-pushed the junghyeonsu/footer-block-preview branch from 24fdb01 to eb11324 Compare June 23, 2026 11:23
@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Alpha Preview (Stackflow SPA)

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Alpha Preview (Storybook)

@junghyeonsu junghyeonsu changed the base branch from dev to feat/figma-fresh-node-ids June 23, 2026 11:27
junghyeonsu and others added 2 commits June 23, 2026 22:06
Add desktop web Footer component docs covering Anatomy (navigation/info
areas split by a divider), Building Blocks (logo, country selector, sitemap,
policy links, business info, contact, copyright, social links), Presets
(BizProfile, Karrot Business, About Karrot, daangn.com) with a composition
matrix, and Responsive guidelines.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@junghyeonsu junghyeonsu force-pushed the feat/figma-fresh-node-ids branch from eb11324 to 29de604 Compare June 23, 2026 13:06
@junghyeonsu junghyeonsu force-pushed the junghyeonsu/footer-block-preview branch from 4a9b56d to 89cf35b Compare June 23, 2026 13:06
Base automatically changed from feat/figma-fresh-node-ids to dev June 23, 2026 14:45
@junghyeonsu junghyeonsu merged commit f367be9 into dev Jun 23, 2026
5 checks passed
@junghyeonsu junghyeonsu deleted the junghyeonsu/footer-block-preview branch June 23, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants