Skip to content

refactor(react): replace unicode-segmenter with built-in Intl.Segmenter#1745

Draft
te6-in wants to merge 3 commits into
devfrom
feat/chrome-88-intl-segmenter
Draft

refactor(react): replace unicode-segmenter with built-in Intl.Segmenter#1745
te6-in wants to merge 3 commits into
devfrom
feat/chrome-88-intl-segmenter

Conversation

@te6-in

@te6-in te6-in commented Jul 1, 2026

Copy link
Copy Markdown
Member

No description provided.

Drop the unicode-segmenter dependency and split graphemes via the
platform Intl.Segmenter (Chrome 87+/Safari 14.1+/Firefox 125+), which is
covered by the new Chrome 88 / Safari 15 support baseline. The public
interface of useTextFieldWithGraphemes is unchanged.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Jul 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: b10abf4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@seed-design/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e2ef12c3-5574-4f1d-bc6a-fa48eefa8985

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/chrome-88-intl-segmenter

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Alpha Preview (Stackflow SPA)

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Alpha Preview (Storybook)

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Alpha Preview (Docs)

te6-in and others added 2 commits July 1, 2026 12:53
Move the segmenter and grapheme memoize cache from module scope into the
hook so importing @seed-design/react no longer constructs Intl.Segmenter at
module-eval time. Only a mounted TextField that uses graphemes creates it,
scoping the unsupported-runtime failure to that component.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant