add charset attribute to script tag for simple-jekyll-search#1438
Open
chanwoo040531 wants to merge 2 commits intodaattali:masterfrom
Open
add charset attribute to script tag for simple-jekyll-search#1438chanwoo040531 wants to merge 2 commits intodaattali:masterfrom
chanwoo040531 wants to merge 2 commits intodaattali:masterfrom
Conversation
Owner
|
I couldn't find any examples of other projects using this script line. Can you show me a usecase where not using this charset causes issues so that I can understand it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
charset="utf-8"attribute to the<script>tag forsimple-jekyll-search. This update ensures proper support for multilingual search.