Add Django 5.2 and 6.0 to test matrix, remove Python 3.8 and 3.9#59
Conversation
dabapps-robot
left a comment
dabapps-robot
left a comment
There was a problem hiding this comment.
Nice update overall — this keeps the support matrix current and the README in sync with what CI is testing. I also like that you’ve explicitly excluded unsupported Python/Django combinations rather than silently relying on failures.
One thing I’d suggest double-checking before merge:
- GitHub Action major versions: you’ve moved to
actions/checkout@v6andactions/setup-python@v6. Can you confirm those majors are available and intended here? (Historically these actions have lagged behind that.)
If not, CI will fail early, so it’s worth validating the tags.
Aside from that, this looks good to me.
dabapps-robot
left a comment
dabapps-robot
left a comment
There was a problem hiding this comment.
Nice update — the matrix exclusions and README/docs links all look consistent with the new support policy.
Only outstanding item from my previous review: actions/checkout@v6 and actions/setup-python@v6 are still in the workflow. Please just confirm those major tags are valid/published (or switch to the latest published majors) so CI doesn’t fail before tests start. If that’s already verified, this looks good to merge.
3 participants
Remove unsupported versions of Django and add latest.