Modernise build tooling and configuration#60
Open
MarkBird wants to merge 1 commit into
Open
Conversation
dabapps-robot
self-requested a review
February 26, 2026 15:37
dabapps-robot
left a comment
There was a problem hiding this comment.
Nice PR — this is a solid modernisation overall. Moving to pyproject.toml + python -m build + gh-action-pypi-publish is a good cleanup, and the workflow updates look much more maintainable than the old setup.py publishing path.
A couple of things I’d like to flag:
-
Python support changed (
>=3.6→>=3.10)- That’s a significant compatibility drop. If intentional, I’d suggest calling it out clearly in the changelog/release notes (and potentially considering whether this warrants a major version bump depending on your versioning policy).
-
zen_queries.__version__was removed- Even though packaging metadata now owns the version (which is good), some consumers may still import
__version__from the package. - Might be worth keeping a compatibility shim for now (or documenting the removal as a breaking change).
- Even though packaging metadata now owns the version (which is good), some consumers may still import
-
PyPI publishing prerequisite
- The new OIDC-based publish step is great, but it depends on PyPI Trusted Publisher configuration being in place for this repo/workflow. Worth double-checking before merge to avoid first-release surprises.
Overall: looks good, with the above compatibility points worth confirming before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transition the project from the old-school setup.py style to the more modern pyproject.toml approach.