Implement ERC165 interface support and initializers#25
Merged
Conversation
- Add ERC165Storage struct for managing interface support mappings - Implement registerInterface() to mark ERC165 interface as supported - Fix supportsInterface() to correctly compute storage keys for interface lookups - Use proper storage slot computation: keccak256(abi.encode(interfaceId, ERC165_STORAGE_LOCATION))
- Add ERC165 interface constants to DiamondLib for IDiamondCut and IDiamondLoupe - Implement registerInterface() in DiamondLib to register Diamond-specific interfaces - Implement registerInterface() in OwnableLib to register ERC173 (Ownership) interface - Update constants to use proper ERC7201 storage location computation
- Create DiamondInit to register IDiamondCut and IDiamondLoupe interfaces - Create ERC165Init to register ERC165 interface support - Update OwnableInit to use init() signature (calls registerInterface via OwnableLib) - Maintain consistency across all initializers for interface registration
- Update DeployDiamond to use MultiInit with DiamondInit, ERC165Init, and OwnableInit - Ensure all required interfaces are registered during diamond initialization - Update InitializableTester to deploy all initializers and test interface registration - Fix testMultiInitSetsOwnerAndInterfaces to properly verify all interface support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the ERC165 interface by implementing storage management and registration functions. Introduce initializers for diamond contract setup, ensuring all necessary interfaces are registered during deployment. Update tests to validate the interface registration process.