Omit empty modules when translating to Go #5766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How is this PR doing @robin-aws ? |
|
Just need to beef up (or tasty-vegetarian-option-up :) the test to actually assert the empty modules aren't emitted, will try to do that today! |
MikaelMayer
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The empty parent modules of a Dafny module like
A.B.Ccan cause trouble in Go when trying to use--go-module-name- these aren't recorded in translation records since they can appear in multiple compilation units. This may need to be extended to other target languages in the future.How has this been tested?
GoEmptyParentModules.dfy, which uses
CHECK-NOTto assert the empty modules don't show up in the translated code.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.