Feat rust better optimization fix #5771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssomayyajula
previously approved these changes
Sep 16, 2024
ssomayyajula
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A recent Rust PR tackled a Dafny-to-Rust soundness issue by making all references to self mutable. This had a lot of problematic implications, such as the impossibility to nest function calls, and in the future to have general traits.
This PR fixes the soundness issue with another way, to prevent the inlining of a function that otherwise Rust's global analysis might determine is safe to remove when it is not for Dafny.
How has this been tested?
A test that I checked was failing without the
[inline(never)]annotation now succeeds.Fixes #5774 and I added it as a test case as well.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.