Chore: Rust refactorings #5786
Merged
Chore: Rust refactorings #5786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow pointer equality now that it's implemented Crashes current Dafny resolver
Refactored more code.
alex-chew
reviewed
Sep 24, 2024
alex-chew
approved these changes
Sep 24, 2024
| if (referential) { | ||
| if pointerType.Raw? { | ||
| r := Error("Cannot compare raw pointers yet - need to wrap them with a structure to ensure they are compared properly"); | ||
| r := Error("Raw pointer comparison not properly implemented yet (need to make comp/rust/traits.dfy to pass with --raw-pointer)"); |
There was a problem hiding this comment.
nit: It seems strange to mention this implementation detail in the error message.
Suggested change
| r := Error("Raw pointer comparison not properly implemented yet (need to make comp/rust/traits.dfy to pass with --raw-pointer)"); | |
| // Need to make comp/rust/traits.dfy to pass with --raw-pointer) | |
| r := Error("Raw pointer comparison not properly implemented yet"); |
| echo "$$count test files found."; \ | ||
| for file in $$files; do \ | ||
| filedir=$$(dirname "$$file"); \ | ||
| (cd "${DIR}/Source/IntegrationTests/TestFiles/LitTests/LitTest/$${filedir}"; "${DIR}"/Binaries/Dafny $(action) "$$(basename $$file)" ); \ |
There was a problem hiding this comment.
Not blocking since this doesn't appear to be used for any automation, but I would suggest using dotnet run ... instead of Binaries/Dafny to prevent the mistake of running make test-run ... on an outdated binary.
MikaelMayer
added a commit
that referenced
this pull request
Sep 25, 2024
Follow-up of #5786 with two changes <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only refactorings +
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.