Chore: Fix 'no active test' #5790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyboardDrummer
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5723, likely fixes #5713 and fixes #5759
Description
The CI fails every other run because of some unknown "there is no currently active test"
Based on this discussion:
xunit/xunit#2146
it seems we should try/catch writing to the output channel, which this PR implements
How has this been tested?
The CI should not fail on this PR, and if needed, we can increase assurance that this PR solves the problem correctly.
To ensure the catching code is not deleted, the comment mentions the issue it is fixing.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.