Chore: Printing of Object<string> will now display the string. #5796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-chew
previously approved these changes
Sep 27, 2024
| impl <T: ?Sized + UpcastObject<dyn Any>> DafnyPrint for Object<T> { | ||
| fn fmt_print(&self, f: &mut Formatter<'_>, _in_seq: bool) -> std::fmt::Result { | ||
| write!(f, "<object>") | ||
| let option_string = UpcastObject::<dyn Any>::upcast(self.as_ref()).as_ref().downcast_ref::<String>().cloned(); |
There was a problem hiding this comment.
This clone is avoidable:
Suggested change
| let option_string = UpcastObject::<dyn Any>::upcast(self.as_ref()).as_ref().downcast_ref::<String>().cloned(); | |
| let obj_any = UpcastObject::<dyn Any>::upcast(self.as_ref()); | |
| let option_string = obj_any.as_ref().downcast_ref::<String>(); |
alex-chew
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to wrap Rust's native string in
Object<>while printing will print them correctly. I added a test in DafnyRuntimeRustThis PR might break external code which created
Object<>of things that Dafny did not support originally, but I'm not aware of any other external code that was making use of that. Moreover, there is a workaround by creating the appropriateUpcasttrait.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.