Chore: Ensure we run miri with the tests to detect undefined behavior… #5804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-chew
previously approved these changes
Oct 1, 2024
Co-authored-by: Alex Chew <[email protected]>
|
I have no idea how to solve this issue and after looking around, I couldn't find a solution. Closing this PR until we find something that works, in the meantime, we'll run miri locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and leaks
How has this been tested?
The CI now ensures MIRI runs to test the runtime. It has caught two memory leaks so far, and will ensure to detect undefined behaviors as well. It's not perfect but will do a better job.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.