-
Notifications
You must be signed in to change notification settings - Fork 285
Remove function-context-height variable in Boogie encoding #6046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
RustanLeino
merged 27 commits into
dafny-lang:master
from
RustanLeino:remove-functionHeight
Jan 17, 2025
Merged
Remove function-context-height variable in Boogie encoding #6046
RustanLeino
merged 27 commits into
dafny-lang:master
from
RustanLeino:remove-functionHeight
Jan 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note, the “function specification” SelectWF check was never reached (and was not in the test suite).
# Conflicts: # Source/IntegrationTests/TestFiles/LitTests/LitTest/examples/parser_combinators.dfy.expect # Source/IntegrationTests/TestFiles/LitTests/LitTest/git-issues/git-issue-847.dfy.expect # Source/IntegrationTests/TestFiles/LitTests/LitTest/hofs/Naked.dfy.expect
# Conflicts: # Source/IntegrationTests/TestFiles/LitTests/LitTest/dafny0/SubsetTypes.dfy.expect
typerSniper
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
CanCallis now used everywhere, the Boogie variable$FunctionContextHeightis no longer needed.This PR also removes the variable
$ModuleContextHeight, which has been unused for some time now.Depends on #6045
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.