Fix call stmt reporting #6191
Open
Fix call stmt reporting #6191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 08f9846.
Co-authored-by: Alex Chew <[email protected]>
alex-chew
reviewed
Apr 16, 2025
Comment on lines
624
to
625
| // This used to be 'a || OnlyFalse(a)' | ||
| // but that stopped working for unknown reason |
There was a problem hiding this comment.
Does this need follow-up?
There was a problem hiding this comment.
I don't know. I don't understand the test generation well enough to know what is expected behavior. I'll ask @robin-aws to have a look, maybe he knows.
There was a problem hiding this comment.
Looks like the test generation is sensitive to token centers and has a few calls to the CallStmt constructor for resolved statements that needed to be updated to preserve the old behavior. I've pushed a commit that fixes this test at least.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed?
How has this been tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.