Add fix for exception that could occur when using includes and top level members #6214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikaelMayer
reviewed
May 2, 2025
| void AddMethod_Top(MethodOrConstructor m, bool isByMethod, bool includeAllMethods) { | ||
| if (!includeAllMethods && !InVerificationScope(m) && !referencedMembers.Contains(m)) { | ||
| if (!includeAllMethods && | ||
| !m.EnclosingClass.EnclosingModuleDefinition.EnclosingLiteralModuleDecl.ShouldVerify(program.Compilation) && |
There was a problem hiding this comment.
I still don't know what InVerificationScope means so this predicate looks more meaningful.
docs/news/6192.fix
Outdated
| @@ -0,0 +1 @@ | |||
| Add fix for exception that could occur when using includes and top level members No newline at end of file | |||
There was a problem hiding this comment.
Suggested change
| Add fix for exception that could occur when using includes and top level members | |
| One less exception when using includes and top level members |
Otherwise this will be rendered in the release notes as
"Fix: Add fix for exception that could occur when using includes and top level members"
keyboardDrummer
force-pushed
the
includeAndTopLevelMembers
branch
from
8b346a8 to
2642035
Compare
MikaelMayer
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6192
What was changed?
Add fix for exception that could occur when using includes and top level members
How has this been tested?
Added test
ast/files/defaultModuleAndInclude/root.dfyBy submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.