Class Invariants: Resolution and Wellformedness #6255
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: source under SyntaxDeserializer needs to be properly regenerated TODO: tests for parsing and resolving need to be completed
…into feat-invariants
If the purpose of this is just to disallow certain fields from being mentioned, then I suggest doing this in a resolver pass after |
|
Oh I see, is it fragile because either the inherited fields of a class are not fully resolved or the field reference in question is not by the time the check is made in |
robin-aws
requested changes
Jun 5, 2025
Source/IntegrationTests/TestFiles/LitTests/LitTest/invariants/Expressivity.dfy
Outdated
Show resolved
Hide resolved
Source/IntegrationTests/TestFiles/LitTests/LitTest/invariants/ReadsError.dfy
Outdated
Show resolved
Hide resolved
Source/IntegrationTests/TestFiles/LitTests/LitTest/invariants/Baseline.dfy
Show resolved
Hide resolved
Source/DafnyCore/Resolver/PreType/PreTypeResolve.Expressions.cs
Outdated
Show resolved
Hide resolved
Source/DafnyCore/Resolver/PreType/PreTypeResolve.Expressions.cs
Outdated
Show resolved
Hide resolved
…Expressivity.dfy Co-authored-by: Robin Salkeld <[email protected]>
Co-authored-by: Robin Salkeld <[email protected]>
…dingly - Wellformedness checks simplified, since they do not have to be scoped to an enclosing declaration - VerifyInvariants renamed to CheckInvariants and is automatically checked when a MemberDecl is coerced to an Invariant - Refinement is now implemented, solving issue in InheritedMemberError.dfy - Printing now implemented
…om invariants to be done as a visitor-based check
RustanLeino
reviewed
Jun 18, 2025
Source/IntegrationTests/TestFiles/LitTests/LitTest/invariants/Counter.dfy
Outdated
Show resolved
Hide resolved
Source/IntegrationTests/TestFiles/LitTests/LitTest/invariants/ReadsError.dfy.expect
Outdated
Show resolved
Hide resolved
Source/IntegrationTests/TestFiles/LitTests/LitTest/invariants/InheritedMemberError.dfy.expect
Outdated
Show resolved
Hide resolved
Source/IntegrationTests/TestFiles/LitTests/LitTest/invariants/Expressivity.dfy
Show resolved
Hide resolved
Source/IntegrationTests/TestFiles/LitTests/LitTest/invariants/InheritedMemberError.dfy
Show resolved
Hide resolved
…f rewriting and axioms
…on, keeping invariant-as-predicate
|
Closing in favor of #6313 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed?
Invariantis aMemberDeclthat holds all of the invariant clauses of an enclosing class (could be any type, but the wellformedness checks currently only make sense for classes). There is not yet a correspondingMemberSelectExpr(in fact, it won't even parse).InvariantChecker)BoogieGeneratormodified to add well-formedness checks for classes, largely copied from function well-formedness checks. A collection of invariants for a class induces the usual expression well-formedness checks + a check that they only readthis--check-invariantsis enabled (used to be--verify-invariants).I want explicit feedback on any comments marked
TODO(usually text of error messages).How has this been tested?
Tests under
Source/IntegrationTests/TestFiles/LitTests/LitTest/invariants/.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.